make stat.FILE_ATTRIBUTE_* available on all platforms #14866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ravencentric
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I'm not sure how to make pyright happy here. Fixing windows breaks Linux and vice versa.
|
Contributor
Author
|
Should I import every symbol explicitly like |
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Oh hmm. Maybe I led you astray then and your original version was fine. Sorry about that! (For what it's worth, importing every symbol isn't as bad as it sounds, since stubtest will tell us if things go out of sync)
Contributor
Author
|
In that case, I'll import the symbols explicitly because I wasn't much of a fan of the weird |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@hauntsaninja This is ready for review 🎉 |
Ravencentric
changed the title
Contributor
Author
|
Gentle bump |
Ravencentric
force-pushed
the
issues/14865
branch
from
d55212e to
45deebf
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14865